SlotFill: Refactor <Slot bubblesVirtually />
#53272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torounit
added
[Type] Code Quality
|
Size Change: +1 B (0%) Total Size: 1.51 MB
ℹ️ View Unchanged
|
|
I think @jsnajdr could help with a review here since I know he recently spent some time understanding the two different versions of |
jsnajdr
reviewed
Aug 14, 2023
packages/components/CHANGELOG.md
Outdated
| @@ -2,6 +2,10 @@ | |||
|
|
|||
| ## Unreleased | |||
|
|
|||
| ### Internal | |||
| - `SlotFill`: Refactor `<Slot bubblesVirtually />` ([#53272](https://github.com/WordPress/gutenberg/pull/53272)) | |||
There was a problem hiding this comment.
As a changelog entry, "refactor" doesn't say anything meaningful. Let's describe the user-visible change in <Slot bubblesVirtually>: when rendered with children, it will ignore them. Previously they would be rendered.
| @@ -41,7 +49,11 @@ function Slot( | |||
| } ); | |||
|
|
|||
| return ( | |||
| <Component ref={ useMergeRefs( [ forwardedRef, ref ] ) } { ...props } /> | |||
| <View | |||
There was a problem hiding this comment.
Do we need to use the View component here? Seems to me that the original div was fine, and that now we're just adding more indirection and complexity. Is there any tangible benefit from the fact that the div is now styled with Emotion?
There was a problem hiding this comment.
@jsnajdr Thanks.
In the original Pull Request, I changed to View to avoid error: TS2590, which I am trying to address in this PR.
There was a problem hiding this comment.
I see, so it's not because of View functionality, but to solve a typing problem. Hopefully in future, when the rename from JS to TS is done, we can find a way to go back to simple div.
jsnajdr
approved these changes
Aug 21, 2023
torounit
force-pushed
the
refactor/slotfill-bubbles-virtually-slot-children
branch
from
bbee740 to
362b6d4
Compare
|
@jsnajdr Thank you for reviewing! |
ciampo
reviewed
Sep 8, 2023
| @@ -46,7 +49,6 @@ | |||
|
|
|||
| - `ColorPalette`, `BorderControl`: Don't hyphenate hex value in `aria-label` ([#52932](https://github.com/WordPress/gutenberg/pull/52932)). | |||
| - `MenuItemsChoice`, `MenuItem`: Support a `disabled` prop on a menu item ([#52737](https://github.com/WordPress/gutenberg/pull/52737)). | |||
| - `TabPanel`: Introduce a new version of `TabPanel` with updated internals and improved adherence to ARIA guidance on `tabpanel` focus behavior while maintaining the same functionality and API surface.([#52133](https://github.com/WordPress/gutenberg/pull/52133)). | |||
There was a problem hiding this comment.
This is a mistake. Commit to PR #51350.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
part of #51350
see: https://github.com/WordPress/gutenberg/pull/51350/files#r1223434900
Why?
Separated the changes made in #51350 that should be handled as a separate PR.
How?
<Slot bubblesVirtually />is not supportchildrenfunction prop now. So, removechildren.<View>.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast